Comments on: Quick iPhone Dev Tip: Creating an UIColor with just one RGB value

By: dbo

dbo — Fri, 25 Dec 2009 18:19:08 +0000

Its so obvious that Im pretty sure that kind of method will be avaliable soon in the next SDK. Its a MUST! Thanks for your work, Mr FriendOfDesigner!

By: pegolon

pegolon — Sat, 03 Oct 2009 04:44:02 +0000

Thank you very much, Mr Aloha, for being so supportive.

By: mr Aloha

mr Aloha — Fri, 02 Oct 2009 08:57:28 +0000

@ this Amin guy: I’ve come across your comments here and there every once in a while. And your attitude slowly starts to annoy me. We all try to get our work done in one way or another and we try to meet the projects requirements as good as we can. So I believe it does not help anyone to criticise his/her approach in this way. Concerning this specific matter: May be your projects are not as visually oriented as others’. In my world designers talk Hex colors. Photoshop just does not show colors with values ranging from 0 to 1. If you prefer to translate the color by hand that’s cool for you BUT I have to skin my application with a whole lot of colors I get in Hex. This little macro does exactly what I need so please relax and let us do things our way. – Talking about bad/good code: Hex colors make code easier for me since I can find my colors and alter them. For me three values ranging from 0 to 1 each seem strange and I can’t interpretate them. They don’t tell me anything. So please stay in your pseudo scientific world, write your next book and let us others get our work done!

By: pegolon

pegolon — Mon, 31 Aug 2009 10:36:14 +0000

Thank you, Torsten!

By: Torsten Curdt

Torsten Curdt — Mon, 31 Aug 2009 10:30:01 +0000

The only problem I see here is the computation vs the dispatch. Arguing that it’s the “right thing” ™ to use a 0..1 range is useless as this is just a convenience macro. I don’t see what is so wrong to define the color components in the 0..255 range instead. After all it’s just a factor. And for what it’s worth – most designer (I have worked with) do provide colors in that very format. Those hex digits are everywhere. Maybe you need to do a reality check there, Amin?

By: pegolon

pegolon — Fri, 12 Jun 2009 03:58:41 +0000

What kind of string do you want to put in it? BTW: it is no function, it is a macro, so it will be converted by the C preprocessor into plain C code.
Cheers,
Markus

By: Chris the wild man

Chris the wild man — Mon, 08 Jun 2009 13:35:14 +0000

I can not seem to figure out how to put an nsstring into this function. I’ve been searching everywhere. Please help! Thanks for the code.

By: walty

walty — Thu, 18 Dec 2008 10:22:01 +0000

actually I did not look in detail about the comments. Anyway, this is very useful for me, thx a lot!

By: Craig Cunic

Craig Cunic — Sat, 13 Dec 2008 12:20:03 +0000

Very handy and very ridiculous to categorize as “bad design”
New to Mac and iPhone.
This is what I would have expected the foundation to have

By: Amin Negm-Awad

Amin Negm-Awad — Wed, 19 Nov 2008 10:54:44 +0000

I don’t use it and I feel free to comment it. And I think, that it is a good idea to comment it. Otherwise readers of this article will think, that this code is good design.

1. This floating point values are not strange. Using the rgb color system you mix up components. It is a very usual way to specify a compnents by a range between 0 and 1. And as I said: It is without a context, especially a context as “typically color encoding on a devie developed in the early 2000’s”

In contrast to this a 24-bit expression (any integer range) of the components are related to a specific context (in this case: usual encoding of colors on a computer). if a device supports a better color resolutions than a random integer range, you will not get it.

2. The correct representation of a value does not depend on the fact whether you are developing a framework or not. You represent the value correct or not.

3. We have three floating point computations for that and one method dispatch. This is no problem. However this computation does not apologize poor design. If it is too slow, you have to caluclate it your own.

Simply try this:
int colorIndex =0;
while( colorTable[colorIndex] ) {
UIColor shade = UIColorFromRGB( color[colorIndex++] );
// …
}

Result: Probably a crashing app, definetly not the intended result